Standard keystroke hijacking bugs in SQL source control
LouisSomers
Posts: 24 Bronze 2
When editing a remark in the main Commit tab, I'd typically select some text from the bottom compare pane, for example the name of the stored procedure or a comment. Hitting CTRL-C does not do what I'd expect it to do, previously I would get an exception pop-up, that seems to be fixed but it still does not copy the selected text. A workaround is to use the context menu "copy".
Also in the comment edit box, CTRL-C does not copy selected text. The Delete button does not delete the selected text, instead it shows a dialog wanting to roll back the selected change in the middle pane. Not at all what I intended. It would be a horror to accidentally hit enter right after deleting a part of a comment!
Other keystrokes are working normally, CTRL-A selects all the text. Backspace still deletes the selected text. CTRL-V pastes text correctly. So it's just a subset of keystrokes.
To summerize:
CTRL-C should check what pane has the focus, and copy the selected text when it's the bottom compare pane or the comment edit box.
DELETE should remove the selected text when the edit box has focus (or remove proceeding character, as delete would normally behave in an edit box).
The current treatment of those keystrokes should only apply when the middle grid/checkbox pane has focus. Not sure what CRTL-C would actually do there though.
Also in the comment edit box, CTRL-C does not copy selected text. The Delete button does not delete the selected text, instead it shows a dialog wanting to roll back the selected change in the middle pane. Not at all what I intended. It would be a horror to accidentally hit enter right after deleting a part of a comment!
Other keystrokes are working normally, CTRL-A selects all the text. Backspace still deletes the selected text. CTRL-V pastes text correctly. So it's just a subset of keystrokes.
To summerize:
CTRL-C should check what pane has the focus, and copy the selected text when it's the bottom compare pane or the comment edit box.
DELETE should remove the selected text when the edit box has focus (or remove proceeding character, as delete would normally behave in an edit box).
The current treatment of those keystrokes should only apply when the middle grid/checkbox pane has focus. Not sure what CRTL-C would actually do there though.
Tagged:
