Merge assembly wrong if its class is used in attribute.

mousehuang

Have one assembly ClassLibrary1:

namespace ClassLibrary1
{
    public class ClassA
    {
    }

    public class ClassB
    {
    }
}

And another assembly ClassLibrary2:

namespace ClassLibrary2
{
    [System.ComponentModel.LicenseProvider(typeof(ClassLibrary1.ClassB))]
    [System.ComponentModel.TypeConverter(typeof(ClassLibrary1.ClassA))] //PROBLEM! It still reference to the old ClassLibrary1.    
    public class Class1
    {
        
        public void Method1()
        {
            Type t = typeof(ClassLibrary1.ClassA); //OK! It reference to the new merged class in ClassLibrary2            
            ClassLibrary1.ClassB b = new ClassLibrary1.ClassB();
            Console.WriteLine(t.ToString());
        }
    }
}

ClassLibrary1 is referenced by ClassLibrary2. I tried to merge ClassLibrary1 into ClassLibrary2. The build is successful. The type "ClassLibrary1.ClassA" used in the Method1 reference to the new merged class in new ClassLibrary2. It is OK. But the type "ClassLibrary1.ClassA" used in the TypeConverterAttribute still reference to the old ClassLibrary1. Enven if its name is obfuscated to the new merged class in new ClassLibrary2. It is wrong.
This problem occurs after upgrating from {SA} 3 to {SA} 5.5. Is it a problem or some settings I should take care are missing?

Chris.Allen

I'm sorry - I'm a little bit confused- are you showing the code before it gets processed or after (i.e. the Reflector output)?

If its before the porcesing- why are you using the TypeConvertor attributes and how exactly are you expecting smartassembly to deal with them?

mousehuang

The code is before obfuscate. Since the ClassLibrary1 is merged to ClassLibrary2, the code of problem line after obfuscate should be: (if ClassLibrary1.ClassA is renamed to "CL1.CA"):
[System.ComponentModel.TypeConverter(typeof([ClassLibrary2:]CL1.CA))].
But now it is:
[System.ComponentModel.TypeConverter(typeof([ClassLibrary1:]CL1.CA))]
Do you notice the problem. The class name changes to "CL1.CA", but the referenced assembly is still ClassLibrary1. It should reference to the new ClassLibrary2, since the class is merged to it.

BTW, the TypeConvertorAttribute is used for design time support.

Chris.Allen

Thank you for the extra clarification- I am going to have to ask for help from one of our experts- please wait while I do this...

Chris.Allen

Looks like this is just not yet supported- sorry. I will log a bug and this will get seen to at some point (I cannot be specific about when).

mousehuang

Thanks for you reply. Waiting...

Chris.Allen

Looks like we fixed it straight away. Please test with our early access release (installs side-by-side with current version):

http://www.red-gate.com/messageboard/vi ... hp?t=12254

mousehuang

It works now. Thanks for you effort. It is noticed that the new version is 6.0. When will the 6.0 be released to public? We had just bought the server license for 5.5, is that license working for 6.0?

Chris.Allen

It should be publically available in January (sorry, can't be more specific). The version 5 license won't apply but if you have a current maintenance contact we will create a new code for you.